More detailed defaults for problem.get_full_vector
#1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1393 +/- ##
===========================================
+ Coverage 84.50% 84.52% +0.02%
===========================================
Files 157 157
Lines 12955 12958 +3
===========================================
+ Hits 10947 10953 +6
+ Misses 2008 2005 -3 ☔ View full report in Codecov by Sentry. |
…vor of lb_full and ub_full.
Doresic
approved these changes
May 6, 2024
m-philipps
reviewed
May 7, 2024
m-philipps
reviewed
May 7, 2024
m-philipps
reviewed
May 7, 2024
m-philipps
approved these changes
May 7, 2024
Co-authored-by: Maren Philipps <55318391+m-philipps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the doctoring already explained before, we usually want
problem.x_fixed_valsas defaults if we update a vector x. I think this should be a default and leaving the nans should be left for gradients (hence another parameter to distinguish the two.